baget: remove due to upstream being unmaintained #222006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
pennae
reviewed
Mar 19, 2023
mdarocha
force-pushed
the
remove-baget
branch
2 times, most recently
from
05d8ca0 to
d96d9d8
Compare
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1966 |
mdarocha
changed the title
| @@ -65,7 +65,7 @@ In addition to numerous new and upgraded packages, this release has the followin | |||
|
|
|||
| - [ArchiSteamFarm](https://github.com/JustArchiNET/ArchiSteamFarm), a C# application with primary purpose of idling Steam cards from multiple accounts simultaneously. Available as [services.archisteamfarm](#opt-services.archisteamfarm.enable). | |||
|
|
|||
| - [BaGet](https://loic-sharma.github.io/BaGet/), a lightweight NuGet and symbol server. Available at [services.baget](#opt-services.baget.enable). | |||
| - [BaGet](https://loic-sharma.github.io/BaGet/), a lightweight NuGet and symbol server. Available at services.baget. | |||
There was a problem hiding this comment.
Please revert this or does it fail to build now? Is that an issue with CI?
cc @pennae
There was a problem hiding this comment.
with the option going away from the generated docs the anchor dies, and the docs build will flag that as an error.
JamieMagee
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
baget is the last package in
nixpkgsdepending on the deprecated .NET 3.1. Unfortunately, the upstream maintainer is inactive for a long time, and in #202572 we decided it will the best to remove it.Required to finish up #202572.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)